[pacman-dev] [PATCH 2/4] makepkg: svn: update existing sources in srcdir without removing them first.

[Allan McRae]

On 10/12/13 18:48, Lukas Jirkovsky wrote:
> On Mon, Dec 9, 2013 at 9:45 PM, Dave Reisner <d at falconindy.com> wrote:
>>
>> What about deleted files? This will break builds...
> 
> I'm aware of that. Usually the left over files cause no problems, but
> I can think of some (crappy) build system that just compiles
> everything that you throw at it in which case renamed files would
> cause conflicts during compilation.
> 
> I've tried a few packages and I had no problems so far. For me the
> possibility to do incremental builds outweighs the possible problems.
> Fortunately I don't use many packages that still use SVN.

There will be plenty of build systems that will use @.c  (made up
psuedo-make syntax) to compile all files.

Lets weigh this up:
 - incremental builds are a big gain
 - it is would seem more likely files are added than removed
 - we have the -C option to do a clean build if needed (a.k.a current
behavior)

I'd suspect that anyone doing an incremental build that failed would be
likely to try a clean build anyway.


So, I think this is a net gain and should be pulled.

@Dave: does that make sense to you?

Allan