[pacman-dev] [PATCH 5/7] fix off-by-one error in _alpm_filelist_resolve

Allan McRae allan at archlinux.org
Thu Feb 14 08:42:22 EST 2013

On 14/02/13 23:30, Andrew Gregory wrote:
> On Thu, 14 Feb 2013 22:12:59 +1000
> Allan McRae <allan at archlinux.org> wrote:
>> On 14/02/13 09:54, Andrew Gregory wrote:
>>> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
>>> ---
>> OK...   I'm tired, so feel free to point out where I am wring here...
>> AFAIK, realpath will not return a trailing "/".  So what is being fixed
>> here?  If I take out the unneeded if statement, if am failing to see the
>> off-by-one error...
> Realpath does include a "trailing" '/' when root == "/".  That's why
> this was passing the test suite.  You can see the error by building a
> package with a file in /lib and then updating it with the file
> in /usr/lib.

I see...   It would really help if you added comments like this to the
commit message.

Ack with a detailed commit message.


More information about the pacman-dev mailing list