[pacman-dev] [PATCH] Provide full path names in warning messages

Allan McRae allan at archlinux.org
Mon Jan 28 00:23:16 EST 2013


On 27/01/13 12:40, Richard Pougnet wrote:
> Somehow I turned FS#31556 into 58. Either I was really tired or not
> thinking, or maybe a bit of both. The real bug number is FS#31556. Any more
> comments before I make another resubmit?


One last comment....    why split this string at all?

> -		_alpm_log(handle, ALPM_LOG_DEBUG, "%s is in NoExtract, skipping
extraction\n",
> -				entryname);
> +		_alpm_log(handle, ALPM_LOG_DEBUG, "%s is in NoExtract, skipping
extraction \
> +		 of %s\n", entryname, filename);
>  		alpm_logaction(handle, "note: %s is in NoExtract, skipping
extraction\n",
>  				entryname);


Just move the whole string onto the next line if it is too long.

Allan


More information about the pacman-dev mailing list