[pacman-dev] [PATCH 4929/4929] Make sed follow symlinks on Linux Signed-off-by: Maxime Gauduin <alucryd at gmail.com>

[Maxime Gauduin]

On Mon, Jan 28, 2013 at 6:31 AM, Allan McRae <allan at archlinux.org> wrote:

> On 27/01/13 19:16, Maxime Gauduin wrote:
> > From: Alucryd <alucryd at gmail.com>
> >
> > ---
>
> Patch is fine.
>
> Just a couple of tips for creating git patches.  The commit messages goes:
>
> Title
> <blank line>
> description if needed
> <blank line>
> Signed-off-by:
>
> If you do "git commit -s" the signed off line is automatically added in
> the right place.
>
> Also, you can make a single patch of the top commit with "git
> format-patch HEAD^"
>
> I will fix the subject/signoff as I commit.
>
> Allan
>
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index e89d4fc..b1ff040 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -299,7 +299,7 @@ GCC_GNU89_INLINE_CC
> >  # Host-dependant definitions
> >  INODECMD="stat -c '%i %n'"
> >  SIZECMD="stat -c %s"
> > -SEDINPLACE="sed -i"
> > +SEDINPLACE="sed --follow-symlinks -i"
> >  DUFLAGS="-sk --apparent-size"
> >  STRIP_BINARIES="--strip-all"
> >  STRIP_SHARED="--strip-unneeded"
> >
>
>
>

Thank you for the tips. I had read that "git format-patch commit_id" would
give me the patch I wanted, but I only managed to have all patches
generated. Maybe I put the wrong ID. And thank you for fixing the
description.

Maxime