[pacman-dev] [RFC] libalpm: replace deprecated libarchive calls

[Allan McRae]

On 29/01/13 04:57, Dave Reisner wrote:
> This raises our minimum libarchive version to 3.0.0, which is reflected
> by autoconf.
> 
> Signed-off-by: Dave Reisner <dreisner at archlinux.org>
> ---
> There's a soname bump with libarchive 3.1 (which no one in Arch Linux land has
> been brave enough to touch yet). Maybe this will help us get started. The test
> suite still passes, though there is a CPIO based failure in libarchive 3.1.1
> which should be dealt with separately.
> 
> I mark this as an RFC since it's a library requirement bump. As an alternative,
> I propose that we could create a header, perhaps lib/libalpm/libarchive.h which
> has wrapper methods and preprocessor logic to Do The Right Thing™. Personally, I'd
> rather not get into this business.


So....

Technically we need libarchive-3.1 or a patched 3.0 (as in the Arch
repos) to use the mtree functionality due to creation being broken
before that.   Although, Dave tells me that mtree creation is completely
broken with 3.1.   But that is only needed for package creation - do we
need to sync versions for package creation and reading?

Dan also has a patch to bring back libarchive-2.8 compatibility[1], but
this was before using the deprecated functions would issue a warning
breaking our development that uses -Werror.

[1]
http://code.toofishes.net/cgit/dan/pacman.git/commit/?h=libarchive-2.8&id=e5dda277

I am happy for the minimum to be set to the future 3.1.1 - or whatever
released version gets mtree generation right...  If someone wants to do
the wrapper/preprocessor stuff to get it working for earlier libarchive
versons, then I would accept patches.  This would need to do the
appropriate disabling of features.

Allan