[pacman-dev] [PATCH v2] [makepkg] Integrate check_install into tidy_install

Chirantan Ekbote chirantan.ekbote at gmail.com
Mon Jan 28 23:33:32 EST 2013


On Mon, Jan 28, 2013 at 10:46 PM, Dan McGee <dpmcgee at gmail.com> wrote:

> On Mon, Jan 28, 2013 at 8:49 PM, Allan McRae <allan at archlinux.org> wrote:
> > On 29/01/13 12:14, chirantan.ekbote at gmail.com wrote:
> >> From: Chirantan Ekbote <chirantan.ekbote at gmail.com>
> >>
> >> Rearrange tidy_install so we first remove docs, unwanted files,
> >> libtool files, and empty directories.  Then check for missing backup
> >> files and references to $srcdir and $pkgdir.  Finally compress manpages,
> >> strip debug symbols, and compress executables with upx.
> >>
> >> Fixes FS33318
> >>
> >> Signed-off-by: Chirantan Ekbote <chirantan.ekbote at gmail.com>
> >> ---
> >
> > Looks good.
>
> FS#xxx would look better than FSxxx, but too late. No auto-linking in
> the commit message on cgit
> (https://projects.archlinux.org/pacman.git/commit/?id=266b3dd706)
> unless you prefix it like that. (For a good example, see
> https://projects.archlinux.org/pacman.git/commit/?id=27067b1372)
>
> -Dan
>
>
Thanks, I'll remember that for the next one :-)

+chirantan


More information about the pacman-dev mailing list