[pacman-dev] $pkgdir value - Was: Update NEWS for pacman-4.1

[Allan McRae]

On 31/01/13 20:47, Allan McRae wrote:
> On 31/01/13 20:38, Allan McRae wrote:
>> On 31/01/13 20:22, Martin Panter wrote:
>>> On 14 November 2012 04:33, Allan McRae <allan at archlinux.org> wrote:
>>>> +              - makepkg:
>>>> +                - require bash>=4.0
>>>> +                - support for VCS URLs (git, bzr, svn and hg) (FS#7816,
>>>> +                  FS#8890, FS#13727, FS#15895, FS#16384, FS#16872, FS#19459,
>>>> +                  FS#19476, FS#20841, FS#21098, FS#28605)
>>>> +                - split debugging symbols into seperate package (FS#10975)
>>>> +                - use SKIP in checksums to skip integrity check (FS#19735)
>>>> +                - add prepare() function to PKGBUILD (FS#30582)
>>>> +                - pkgrel must be in decimal format
>>>> +                - PKGBUILDs without package() functions are depricated
>>>
>>> Maybe also add this, because I’m seeing a few AUR packages that
>>> reference $pkgdir from the build() function and get the incorrect
>>> plain old “pkg” directory.
>>>
>>> - pkg/$pkgname is always used as $pkgdir
>>> - $pkgdir is no longer usable in the build() function
>>>
>>> Also I think the PKGBUILD man page needs updating because it
>>> associates “pkgdir” with the build() function. Unless there is a valid
>>> use for $pkgdir in build() that I am not aware of, in split packages
>>> or something?
>>
>> No...  $pkgdir always points the right place.  It is just no longer
>> $startdir/pkg.
>>
> 
> Sorry - completely misread this.   Did not pick up the build() function
> part.
> 
> This is interesting...  I will look into it further.
> 

OK...  third reply...

For a single package with only a build() function, $pkgdir is
$startdir/pkg/$pkgname in both build() and package().

For a single package with both build() and package() function or a split
package, this is set to $startdir/pkg.   That is wrong, but $pkgdir
should not be touched within the build function.


I am fixing...

Allan