[pacman-dev] [PATCH] makepkg: Log commands to logfile

[Dave Reisner]

On Tue, Jul 02, 2013 at 10:05:00PM +0200, Alain Kalker wrote:
> On 07/02/2013 09:55 PM, Dave Reisner wrote:
> >On Tue, Jul 02, 2013 at 09:40:13PM +0200, Alain Kalker wrote:
> >>For debugging PKGBUILDs, and for reporting build failures upstream,
> >>it is very important to know the exact commands that are executed
> >>leading up to a problem.
> >>By using `set -x` and an appropriate value for PS4, commands are
> >>logged before they are executed.
> >If you want to report build failures upstream, then building via makepkg
> >is already wrong.
> Not if:
> - the build failure is caused by an Autoconf bug (see FS#35983 -
> [libxcb] Build failure: .../install-sh: No such file or directory)

Your patch does nothing to expose the problem you're reporting here.

> - the package is built as vanilla, as possible, as is supposedly the
> Arch Way.

I can guarantee you that any sane upstream will tell you to build as per
*their* instructions (i.e. not using makepkg) if you try and report a
build failure to them. Regardless of how these failures were discovered,
they absolutely require manual verification outside of makepkg.

> - the logged commands fully reflect the build process, i.e. no
> interference from outside environment variables, etc.

Except that by design, specific environment variables are pulled in by
makepkg.

> >
> >-1 on this.
> Please don't NAK just because you disagree on one possible use of
> this feature!
> As I've stated clearly, the patch has other obvious benefits:
> debugging PKGBUILDs.
> Thank you.
> 

You already have the list of commands to be executed right in front of
you. You're running code that you yourself wrote into the PKGBUILD and
nothing more.