[pacman-dev] [PATCH] Do not refer to FlySpray numbers

Allan McRae allan at archlinux.org
Mon Jul 15 10:08:27 EDT 2013


On 15/07/13 23:28, Dan McGee wrote:
> On Sun, Jul 14, 2013 at 11:16 PM, Allan McRae <allan at archlinux.org> wrote:
>> These references to bug numbers assume we will forever be using that bug
>> tracker and all did not provide any information beyond the comment and
>> commit message.
>>
>> Signed-off-by: Allan McRae <allan at archlinux.org>
>> ---
>>
>> Left that FS numbers in the test suite as that requries a much larger
>> clean-up.
> 
> I am OK with this in the code, but I'm not sure I buy your logic for
> the test suite. If a test can be directly attributed to a bug report,
> why would we not want to do so? This is the same reason I refer to
> these numbers in the NEWS file.
> 
> Note that bugs like https://bugs.archlinux.org/task/6246 which were
> referred to below predated the move to git when we were still in CVS;
> thus the idea of a commit message or any sane log mechanism was
> non-existent.
> 
> Even if Flyspray goes away, I doubt we would want to lose it
> completely for some time. There is too much historical data in there
> that might be useful.

My idea is to have the files self contained.  So we should provide
details in the code or test suite of what the bug is that is being fixed
or tested.  That way, we do not need to reply on Flyspray remaining
available, or being accessible.  I find it really annoying to have to
open a web browser and navigate to the right bug report when I need to
understand something.

Allan



More information about the pacman-dev mailing list