[pacman-dev] [PATCH 2/7] makepkg: use output_format, add --quiet option

William Giokas 1007380 at gmail.com
Sun Mar 3 12:19:58 EST 2013


On Mon, Mar 04, 2013 at 03:11:02AM +1000, Allan McRae wrote:
> On 03/03/13 07:50, William Giokas wrote:
> > output_format.sh is now much the same as the original message
> > subroutines, so just use m4_include to pull that in. This also adds a
> > `(( QUIET )) && return` to the output format section, allowing for a
> > --quiet switch to suppress some output.
> > 
> > Signed-off-by: William Giokas <1007380 at gmail.com>
> > ---
> 
> 
> Rejected.  All amkepkg's messages got to stderr, so it can not use
> output_format.

Okay. gtmanfred and I were messing with this last night, and without
that it messed up the pkgver sed expressions. I'd say that we could have
all of the output_format messages to to stderr, but that may not be
really advantageous for the other scripts. Personally, I would do that
since some of the other scripts call commands (like gpg) that people may
want to separate from the scripts output. Guess it's a good thing I
split these up into pieces.

Thanks,
-- 
William Giokas | KaiSforza
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20130303/d64dd30b/attachment.asc>


More information about the pacman-dev mailing list