[pacman-dev] [PATCH 2/7] makepkg: use output_format, add --quiet option

[Allan McRae]

On 04/03/13 03:31, Dave Reisner wrote:
> On Mon, Mar 04, 2013 at 03:11:02AM +1000, Allan McRae wrote:
>> On 03/03/13 07:50, William Giokas wrote:
>>> output_format.sh is now much the same as the original message
>>> subroutines, so just use m4_include to pull that in. This also adds a
>>> `(( QUIET )) && return` to the output format section, allowing for a
>>> --quiet switch to suppress some output.
>>>
>>> Signed-off-by: William Giokas <1007380 at gmail.com>
>>> ---
>>
>>
>> Rejected.  All amkepkg's messages got to stderr, so it can not use
>> output_format.
>>
> 
> Consider that if we're already bent on using m4 for injecting this code
> into the shell script, it stands to reason that we could quite simply
> generate this as the output of an m4 function (instead of a direct
> include) which takes an FD number as a parameter to default the output
> to.
> 

Sure - I'd take that without the --quiet part, which needs separate
treatment

Allan