[pacman-dev] [PATCH] makepkg: Use a recursive git clone.

[Allan McRae]

On 02/03/13 03:41, Neer Sighted wrote:
> Make makepkg use a recursive clone when creating the working directory.
> This will initialize submodules
> ---
>  scripts/makepkg.sh.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index bd29d73..9399aa5 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -490,7 +490,7 @@ download_git() {
>  	pushd "$srcdir" &>/dev/null
>  	rm -rf "${dir##*/}"
>  
> -	if ! git clone "$dir"; then
> +	if ! git clone --recursive "$dir"; then
>  		error "$(gettext "Failure while creating working copy of %s %s repo")" "${repo}" "git"
>  		plain "$(gettext "Aborting...")"
>  		exit 1
> 

This would mean --holdver would not work when a project has submodules
given these would be updated.  Also, that would require an internet
connection during "extracting" the sources, but --holdver is suppose to
allow offline VCS builds.   Is there a way we can avoid this?

Anyone else got anything to add here?

Allan