[pacman-dev] [PATCH] makepkg: Use a recursive git clone.

[Neer Sighted]

On Tue, Mar 5, 2013, at 01:58 AM, Allan McRae wrote:
> On 04/03/13 23:06, Allan McRae wrote:
> > On 04/03/13 22:58, Jan Steffens wrote:
> >> On Mon, Mar 4, 2013 at 1:20 PM, Allan McRae <allan at archlinux.org> wrote:
> >>> This would mean --holdver would not work when a project has submodules
> >>> given these would be updated.  Also, that would require an internet
> >>> connection during "extracting" the sources, but --holdver is suppose to
> >>> allow offline VCS builds.   Is there a way we can avoid this?
> >>>
> >>> Anyone else got anything to add here?
> >>>
> >>> Allan
> >>
> >> The state of the submodules is fixed in the commit of the parent repo
> >> - the submodules are locked to commits as well.
> >>
> >> With --recursive, building with an internet connection would work, but
> >> without would not, as I think it will attempt to get the submodules
> >> from their sources, not the parent repo.
> > 
> > Is it possible to improve on that?  Can we checkout the submodules earlier?
> > 
> >> Without --recursive, building would fail in any case, as the
> >> submodules aren't initialized at all.
> >>
> >> So I think adding --recursive is the right thing to do.
> >>
> 
> Pulling patch - if someone cn figure out how to have submodules and have
> all the source downloaded earlier, that would be good...
> 
> 
> 
> 

Thanks Allan!


-- 
Neer Sighted
http://neersighted.com | neersighted at myopera.com {01DC2056}