[pacman-dev] [PATCH 1/2] testdb: pass empty local pkglist to alpm_checkdeps

Andrew Gregory andrew.gregory.8 at gmail.com
Sat Mar 9 11:59:32 EST 2013


Passing the local package list to alpm_checkdeps as both the local
packages and packages to be upgraded did nothing but cause extra
overhead as the packages were all removed from the installed package
list because they were being upgraded.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 src/util/testdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/testdb.c b/src/util/testdb.c
index 7b08cb0..073acc3 100644
--- a/src/util/testdb.c
+++ b/src/util/testdb.c
@@ -98,7 +98,7 @@ static int check_deps(alpm_list_t *pkglist)
 	alpm_list_t *data, *i;
 	int ret = 0;
 	/* check dependencies */
-	data = alpm_checkdeps(handle, pkglist, NULL, pkglist, 0);
+	data = alpm_checkdeps(handle, NULL, NULL, pkglist, 0);
 	for(i = data; i; i = alpm_list_next(i)) {
 		alpm_depmissing_t *miss = i->data;
 		char *depstring = alpm_dep_compute_string(miss->depend);
-- 
1.8.1.5



More information about the pacman-dev mailing list