[pacman-dev] [PATCH v2] Treat packages to be printed as non-ignored

[Connor Behan]

On 13/03/13 11:04 PM, Allan McRae wrote:
> On 14/03/13 15:51, Connor Behan wrote:
>> Calling pacman -Sp is guaranteed not to install a package. So the user's
>> IgnorePkg pref is still respected regardless of whether or not we print
>> the mirror location. Therefore we might as well do so to give as much
>> information as possible. Also fixes an edge case with devtools.
>>
>> Signed-off-by: Connor Behan <connor.behan at gmail.com>
>> ---
>>  src/pacman/conf.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/src/pacman/conf.c b/src/pacman/conf.c
>> index 3f1b1c3..c982df5 100644
>> --- a/src/pacman/conf.c
>> +++ b/src/pacman/conf.c
>> @@ -1010,6 +1010,13 @@ int parseconfig(const char *file)
>>  	if((ret = _parseconfig(file, &section, 1, 0))) {
>>  		return ret;
>>  	}
>> +	
>> +	/* #FS#34066 - Querying URLs for packages (even ignored ones) should succeed */
>> +	if(config->print) {
>> +		config->ignorepkg = NULL;
>> +		config->ignoregrp = NULL;
>> +	}
>> +	
>>  	if((ret = setup_libalpm())) {
>>  		return ret;
>>  	}
>>
> Nope...    -Sup should still not print Ignored packages.  Also, what
> should be done with packages explicitly ignored on the command line?
>
> Allan
>
>

Hmm yeah. Seeing ignored packages in -Sup would be too weird.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20130313/b54f7065/attachment.asc>