[pacman-dev] [PATCH] makepkg: avoid file|grep dependency for CRLF check

Dave Reisner dreisner at archlinux.org
Sun Mar 24 15:09:18 EDT 2013


Signed-off-by: Dave Reisner <dreisner at archlinux.org>
---
 scripts/makepkg.sh.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 73f45d4..a63b267 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -2744,8 +2744,7 @@ if [[ ! -f $BUILDFILE ]]; then
 		source_safe "$BUILDFILE"
 	fi
 else
-	crlftest=$(file "$BUILDFILE" | grep -F 'CRLF' || true)
-	if [[ -n $crlftest ]]; then
+	if [[ $(<"$BUILDFILE") = *$'\r'* ]]; then
 		error "$(gettext "%s contains %s characters and cannot be sourced.")" "$BUILDFILE" "CRLF"
 		exit 1
 	fi
-- 
1.8.2



More information about the pacman-dev mailing list