[pacman-dev] [PATCH 1/2] Introduce ini.{c,h}

[Sascha Kruse]

2013/3/16 Chirantan Ekbote <chirantan.ekbote at gmail.com>:
> On Fri, Mar 15, 2013 at 7:06 AM, Sascha Kruse <knopwob at googlemail.com>wrote:
>
>> This makes the ini parsing code reusable for future additions like
>> parsing config files for hooks.
>>
>> Signed-off-by: Sascha Kruse <knopwob at googlemail.com>
>> ---

... SNIP ...

>> +#include "util.h"
>> +#include "pacman.h"
>> +
>> +/** Recursivly parse file taking 'Include' directives into account
>>
>
> Small typo here 'Recursivly' -> 'Recursively'

Fixed locally. I'll resubmit with this fix after someone else reviewed this,
since I guess there will be more issues that need to be addressed.

... SNIP ...

> I think the other patch should be combined with this one.  Since you are
> moving code out of one file and into another, it's a little confusing if
> you separate it into two patches.

The reasoning for my decision to separate those patches was that everything
is still working after the first patch.

The first patch adds new functions for config parsing without touching any other
code and the second patch replaces the old code with these functions.

Greetings,
Sascha Kruse