[pacman-dev] [PATCH] pacman/util.c: Fix negative Installed size

[Dave Reisner]

On Thu, May 09, 2013 at 06:27:56PM +0200, Peter Wu wrote:
> Commit ce5ee8a065a590564982191c76cb325ab05e04e2 separated the display of
> Download, Installed/Removed and Upgrade size such that the output can nicely be
> formatted. However, it also changed the data type for storing the actual size.
> 
> Previously it was off_t (sizeof == 8), after that commit is became int (sizeof
> == 4). This patch restores the previous behaviour and shows the expected
> (non-negative) values again.

https://projects.archlinux.org/pacman.git/commit/?id=b5a7734a

> Signed-off-by: Peter Wu <lekensteyn at gmail.com>
> ---
>  src/pacman/util.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/pacman/util.c b/src/pacman/util.c
> index 862c8e8..643b6fe 100644
> --- a/src/pacman/util.c
> +++ b/src/pacman/util.c
> @@ -49,7 +49,7 @@
>  
>  struct table_row_t {
>  	const char *label;
> -	int size;
> +	off_t size;
>  };
>  
>  int trans_init(alpm_transflag_t flags, int check_valid)
> @@ -828,7 +828,7 @@ static alpm_list_t *create_verbose_row(pm_target_t *target)
>  	return ret;
>  }
>  
> -static void add_transaction_sizes_row(alpm_list_t **table, const char *label, int size)
> +static void add_transaction_sizes_row(alpm_list_t **table, const char *label, off_t size)
>  {
>  	struct table_row_t *row = malloc(sizeof(struct table_row_t));
>  
> -- 
> 1.8.2.2
>