[pacman-dev] [PATCH] Improve and colourize VerbosePkgList

[Dave Reisner]

On Wed, May 22, 2013 at 10:18:29AM -0400, Andrew Gregory wrote:
> On 05/22/13 at 03:41am, Simon Gomizelj wrote:
> > +static void free_verbose_cell(void *ptr)
> > +{
> > +	struct verbose_cell_t *cell = ptr;
> 
> This should take a cell pointer, not void and check for NULL like our
> other *_free functions.
> 

Presumably this was done to make it conform to the alpm_list_fn_free
typedef. I think the void* param is fine, especially since this is
strictly internal. The NULL check is certainly worthwhile, though.