[pacman-dev] [PATCH] Revise PKGBUILD(5)

Allan McRae allan at archlinux.org
Wed May 29 08:17:08 EDT 2013


On 29/05/13 21:06, Jason St. John wrote:
> From: "Jason St. John" <jstjohn at purdue.edu>
> 
> Several grammatical errors and minor formatting consistency issues have
> been resolved in PKGBUILD(5).
> ---
> Ignore the patch I submitted just a few minutes ago, and use this patch instead. I
> just noticed a quoting problem introduced in that patch.
> 
> This is a resubmission of a previous patch based on Allan's feedback, which can
> be found here:
> https://mailman.archlinux.org/pipermail/pacman-dev/2013-April/016968.html
> 
> There are some additional changes, but they should be relatively benign.
> 

<snip>

> 
>  *prepare() Function*::
> -	An optional prepare() function can be specified in which operations that
> -	are to be run in order to prepare the sources for building (such as
> -	patching) are performed. This function is run after the source extraction
> -	and before the build() function and is skipped when source extraction is
> -	skipped.
> +	An optional `prepare()` function can be specified in which operations to
> +	prepare the sources for building, such as patching, are performed. This
> +	function is run after the source extraction and before the `build()`
> +	function, and the `prepare()` function is skipped when source extraction
> +	is skipped.

"...function, and the `prepare()`..."

I think that bit sounds a bit wrong now.  Split the sentence.

..and before the `build()` function.  The `prepare()` function is skipped...



Otherwise, all good.

Allan


More information about the pacman-dev mailing list