[pacman-dev] [PATCH] Replace "echo" command with "printf" in human_to_size_test.sh

Allan McRae allan at archlinux.org
Sun Nov 10 01:08:55 EST 2013


On 10/11/13 16:07, Allan McRae wrote:
> On 09/11/13 04:21, Jason St. John wrote:
>> Signed-off-by: Jason St. John <jstjohn at purdue.edu>
>> ---
>> This is yet anoter resubmit.
>>
>> I forgot to add the printf formatter in the previous patch.
>>
>>
>>  test/scripts/human_to_size_test.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/scripts/human_to_size_test.sh b/test/scripts/human_to_size_test.sh
>> index 659d78c..692b89d 100755
>> --- a/test/scripts/human_to_size_test.sh
>> +++ b/test/scripts/human_to_size_test.sh
>> @@ -5,7 +5,7 @@ declare -i testcount=0 fail=0 pass=0 total=15
>>  # source the library function
>>  lib=${1:-${PMTEST_SCRIPTLIB_DIR}human_to_size.sh}
>>  if [[ -z $lib || ! -f $lib ]]; then
>> -	echo "Bail out! human_to_size library ($lib) could not be located\n"
>> +	printf "Bail out! human_to_size library (%s) could not be located\n" "${lib}"
> 
> We need another \n at the end of the printf to keep the output the same.
> 

Ah - I saw that this was discussed and not wanted in an earlier submission.

A



More information about the pacman-dev mailing list