[pacman-dev] Fwd: [PATCH] pacdiff: do not remove pacfile after viewing, but ask user

[Florian Pritz]

On 16.11.2013 11:44, Vasiliy Korchagin wrote:
> I often use pacdiff tool for updating config files. And I find it very 
> inconvenient that after viewing files in vimdiff, I have the only choice 
> to delete pacfile. It would be more useful to ask user what to do next 
> with standard set of choices (view, skip, remove, overwrite).

Looks good. Maybe also print the option string again (I'm never sure if
removing is r or d (for delete)) and possibly also the filenames so it's
easier to see what exactly is going to happen.

We are dealing with system config files mostly so I think a little extra
verbosity about what's going to happen never hurts. Especially
considering that overwriting and removing don't ask for confirmation.

> One line patch is attached.

Please use git-send-email in the future so we can comment inline (most
clients strip the attachment when replying otherwise). Not needed here,
but very useful for larger patches.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/pacman-dev/attachments/20131116/9354dd3d/attachment.asc>