[pacman-dev] [PATCH] Don't truncate display of rules when unit tests are run with "-v".

Andrew Gregory andrew.gregory.8 at gmail.com
Wed Oct 2 11:50:59 EDT 2013


On 10/02/13 at 09:08am, Jeremy Heiner <ScalaProtractor at gmail.com> wrote:
> Signed-off-by: Jeremy Heiner <ScalaProtractor at gmail.com>
> ---
>  test/pacman/pmrule.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/pacman/pmrule.py b/test/pacman/pmrule.py
> index c97a158..b289146 100644
> --- a/test/pacman/pmrule.py
> +++ b/test/pacman/pmrule.py
> @@ -32,7 +32,7 @@ def __init__(self, rule):
>          self.result = 0
>  
>      def __str__(self):
> -        if len(self.rule) <= 40:
> +        if util.verbose or len(self.rule) <= 40:
>              return self.rule
>          return self.rule[:37] + '...'
>  
> -- 
> 1.8.4

Can we just remove the truncation altogether?  Now that `make check`
saves test output to a file, somebody would have to go out of their
way to see the rule by either reading test-suite.log or manually
running pactest.  Either way, I imagine they're more likely to want
the full rule.

apg


More information about the pacman-dev mailing list