[pacman-dev] [PATCH v3 3/4] Moved dependencies of download functions into a library

[Allan McRae]

On 09/10/13 14:40, Allan McRae wrote:
> On 22/09/13 20:25, Ashley Whetter wrote:
>> Moved functions out in preparation for splitting out download functions.
>> scripts/libmakepkg/*.sh files only import the files from their relevant
>> directory.
>> All libmakepkg files have an inclusion guard.
>> Also added libmakepkg targets to Makefile.am.
>>
>> Signed-off-by: Ashley Whetter <ashley at awhetter.co.uk>
>> ---
> 
> Patch is fine but copyright years are excessive in some cases.  As far
> as I can tell, no line has been left untouch by contributors not covered
> by the "Pacman Development Team" banner (apart form function names,
> brackets and whitespace.  So we don not need to propegate those to the
> new files.   Changes I will make while pulling this are noted below.
> 
>>  scripts/.gitignore                 |   4 +
>>  scripts/Makefile.am                |  38 +++++++-
>>  scripts/libmakepkg/util.sh.in      |  30 +++++++
>>  scripts/libmakepkg/util/message.sh |  55 ++++++++++++
>>  scripts/libmakepkg/util/url.sh.in  | 145 ++++++++++++++++++++++++++++++
>>  scripts/libmakepkg/util/util.sh.in |  58 ++++++++++++
>>  scripts/makepkg.sh.in              | 180 ++-----------------------------------
>>  7 files changed, 333 insertions(+), 177 deletions(-)
>>  create mode 100644 scripts/libmakepkg/util.sh.in
>>  create mode 100644 scripts/libmakepkg/util/message.sh
>>  create mode 100644 scripts/libmakepkg/util/url.sh.in
>>  create mode 100644 scripts/libmakepkg/util/util.sh.in
>>

Final note.   New files needed to be added to scripts/po/POTFILES.in.
Done on my working branch.

Allan