[pacman-dev] [PATCH] Add a -C, --cleanbuild option to clear the source directory before building a package.

Lukas Jirkovsky l.jirkovsky at gmail.com
Thu Oct 10 05:29:14 EDT 2013


On Thu, Oct 10, 2013 at 2:41 AM, Allan McRae <allan at archlinux.org> wrote:
> On 04/10/13 23:57, Lukáš Jirkovský wrote:
>> Implements FS#17175.
>
> Grr...    Completely rejected.

No problem, I won't use it anyway ;-)

> Issues:
> 1) it does not remove $srcdir...

Well, it removes contents of the $srcdir just like the message said.
That's because the later code expects $srcdir to exist. Doing "rm -rf
$srcdir && make -p $srcdir" seems a bit superfluous.

> 2) when you fix the "rm -rf" line to do it properly, it deletes
> everything just moved to srcdir (local sources, non-vcs sources...)

I don't see a problem here. I thought that this is what people wanted it to do.

Lukas


More information about the pacman-dev mailing list