[pacman-dev] [PATCH] Update existing sources instead of removing them first for VCS sources.

Allan McRae allan at archlinux.org
Sun Oct 13 04:09:54 EDT 2013


On 11/10/13 18:02, Lukas Jirkovsky wrote:
> On Thu, Oct 10, 2013 at 1:18 PM, Allan McRae <allan at archlinux.org> wrote:
>> I find your explaination of the handling of the fragment in SVN
>> reasonable.  But this needs to be done in a separate patch.  One thing
>> that would need confirmed is changing the value of "revision#..." or
>> removing or adding it works fine.
>>
>> Allan
> 
> What would be the preferred approach? Should I submit patch for the
> SVN first and then this patch, or should I do it differently?
> 

How about a set of patches:

1) Change SVN with your aforementioned reasoning.
2) Change SVN to use "cp -au" if the directory exists in $srcdir
3) Have git update itself rather than delete
...

We will deal with hg/bzr once we have git working properly.

For git, the solution appears to be to always to do the "git checkout
-B" if it is being updated, regardless of if it has a commit/tag/branch
reference or not.  So the check will be:

if [[ -n $ref ]] || (( updating ))

where "updating" records whether or not there was a git checkout in
$srcdir in the first place.

Allan




More information about the pacman-dev mailing list