[pacman-dev] [PATCH] [RFC] pacman -Si/-Qi: Autodetect best fitting file size unit

Florian Pritz bluewind at xinu.at
Thu Oct 17 07:55:10 EDT 2013

I've tracked this back to e223366 and it looks like this just forces KiB
because back then humanize_size didn't exist, but the size was just
divided by 1024 to keep it somewhat readable. When humanize_size got
introduced in 3c8a448 this was just carried over.

Signed-off-by: Florian Pritz <bluewind at xinu.at>

Similar to this -Su also forces units to MiB, but I'm unsure if this should be
changed since -Su outputs a nice table and having everything in the same unit
makes comparing packages easier.

Any input on this patch and the -Su situation would be welcome.

 src/pacman/package.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pacman/package.c b/src/pacman/package.c
index eab2873..b10207b 100644
--- a/src/pacman/package.c
+++ b/src/pacman/package.c
@@ -165,7 +165,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra)
 	deplist_display(_("Conflicts With :"), alpm_pkg_get_conflicts(pkg), cols);
 	deplist_display(_("Replaces       :"), alpm_pkg_get_replaces(pkg), cols);
-	size = humanize_size(alpm_pkg_get_size(pkg), 'K', 2, &label);
+	size = humanize_size(alpm_pkg_get_size(pkg), '\0', 2, &label);
 	if(from == ALPM_PKG_FROM_SYNCDB) {
 		printf("%s%s%s %6.2f %s\n", config->colstr.title, _("Download Size  :"),
 			config->colstr.nocolor, size, label);
@@ -174,7 +174,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra)
 			config->colstr.nocolor, size, label);
-	size = humanize_size(alpm_pkg_get_isize(pkg), 'K', 2, &label);
+	size = humanize_size(alpm_pkg_get_isize(pkg), '\0', 2, &label);
 	printf("%s%s%s %6.2f %s\n", config->colstr.title, _("Installed Size :"),
 			config->colstr.nocolor, size, label);

More information about the pacman-dev mailing list