[pacman-dev] [PATCH] sortbydeps: include local pkgs in dep graph

[Allan McRae]

On 18/10/13 13:38, Andrew Gregory wrote:
> Detecting indirect dependencies by traversing a package's entire
> dependency tree is prohibitively slow for larger transactions.  Instead
> add local packages to the dependency graph.  This additionally requires
> delaying dependency ordering for sync operations so that removed
> packages may be excluded from dependency detection.
> 
> tests/sync012.py was also updated to ensure that the dependency cycle
> was actually detected.
> 
> Fixes FS#37380
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
> 

Have not reviewed the patch itself yet, but the diff between the output
of "pacman -Sg | pacman -Sp -" with and without the patch is:

>  diff -Naur old.txt new.txt
--- old.txt	2013-10-18 14:39:08.001081130 +1000
+++ new.txt	2013-10-18 14:24:34.621969663 +1000
@@ -9,12 +9,12 @@
 http://topsecretserver.org/testing/os/x86_64/logrotate-3.8.7-1-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/bzip2-1.0.6-4-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/coreutils-8.21-2-x86_64.pkg.tar.xz
+http://topsecretserver.org/core/os/x86_64/perl-5.18.1-1-x86_64.pkg.tar.xz
+http://topsecretserver.org/core/os/x86_64/gawk-4.1.0-1-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/shadow-4.1.5.1-6-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/util-linux-2.23.2-1-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/e2fsprogs-1.42.8-1-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/findutils-4.4.2-5-x86_64.pkg.tar.xz
-http://topsecretserver.org/core/os/x86_64/gawk-4.1.0-1-x86_64.pkg.tar.xz
-http://topsecretserver.org/core/os/x86_64/perl-5.18.1-1-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/sed-4.2.2-3-x86_64.pkg.tar.xz
 http://topsecretserver.org/testing/os/x86_64/pacman-4.1.2-2-x86_64.pkg.tar.xz
 http://topsecretserver.org/core/os/x86_64/cronie-1.4.9-5-x86_64.pkg.tar.xz


which obviously is cosmetic.   And a bit over 15 minutes or runtime...

A