[pacman-dev] [PATCH 2/2] copy file siglevels from SigLevel when first seen

Andrew Gregory andrew.gregory.8 at gmail.com
Thu Oct 31 07:45:25 EDT 2013


On 10/31/13 at 04:13pm, Allan McRae wrote:
> On 28/10/13 23:58, Andrew Gregory wrote:
> > Both repo-specific siglevels and file siglevels used the default
> > siglevel as their base.  Previously, repo siglevels inherited when the
> > repo was parsed, but file siglevels inherited after config parsing was
> > complete.  Having both options inherit from the default when they are
> > first parsed is more intuitive and reduces parser complexity.
> > 
> > Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> > ---
> > 
> > This may change how some existing config files are parsed, but I doubt anybody
> > is purposefully using the old behavior.
> > 
> 
> Can you provide details of the old behaviour that is "broken" by this?

Sure, here's an example:

SigLevel = Required TrustedOnly
RemoteFileSigLevel = Optional
SigLevel = TrustAll

Old behavior: RemoteFileSigLevel's final value is Optional TrustAll. 
New behavior: RemoteFileSigLevel's final value is Optional TrustedOnly.

apg


More information about the pacman-dev mailing list