[pacman-dev] [PATCH 1/2] support ALPM_SIG_USE_DEFAULT for file siglevels

[Allan McRae]

On 31/10/13 21:35, Andrew Gregory wrote:
> On 10/31/13 at 04:18pm, Allan McRae wrote:
>> On 28/10/13 23:58, Andrew Gregory wrote:
>>> This brings file siglevels in line with how db siglevels are handled.
>>>
>>> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
>>> ---
>>>
>>> As an aside, why is alpm storing these values at all? They're only used by the
>>> frontend.
>>>
>>
>> Continuing your aside...  aren't these stored in the backend so it can
>> use them for signature verification?   Or am I not understanding your
>> question.
>>
>> A
>>
> 
> alpm never uses the localfilesiglevel or remotefilesiglevel options
> directly.  It only stores them for pacman, which picks the appropriate
> one and passes it to alpm_pkg_load in upgrade.c.  It seems like it
> would make more sense to just store them in the frontend.

Hrm...

I think the frontend should not even need to worry about that.  We could
adjust alpm_pkgfrom_t to distiguish between remote and local files and
then just have libalpm select the appropriate value in alpm_pkg_load
rather than the frontend having to provide it.

A