[pacman-dev] [PATCH 1/2] makepkg: unify list of known hash algorithms

Allan McRae allan at archlinux.org
Tue Sep 3 01:58:33 EDT 2013


On 03/09/13 06:08, Dave Reisner wrote:
> Unifying this list makes adding new algorithms easier. There's also
> some menial cleanup in this patch to avoid use of eval and properly
> treat lists of data as array instead of simple strings.
> 
> Signed-off-by: Dave Reisner <dreisner at archlinux.org>
> ---
>  scripts/makepkg.sh.in | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 025f756..73f4eb7 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -54,6 +54,8 @@ splitpkg_overrides=('pkgver' 'pkgrel' 'epoch' 'pkgdesc' 'arch' 'url' 'license' \
>                      'replaces' 'backup' 'options' 'install' 'changelog')
>  readonly -a packaging_options other_options splitpkg_overrides
>  
> +known_hash_algos=(md5 sha1 sha256 sha384 sha512)

Do we want those values in quotes.  I know it is not strictly necessary,
but it is done in the three lists on the line above that so consistency
would be good.




More information about the pacman-dev mailing list