[pacman-dev] [PATCH] bacman: include BACKUP files

Allan McRae allan at archlinux.org
Mon Sep 16 22:57:50 EDT 2013

On 17/09/13 06:49, Xyne wrote:
> Here is the patch with the aforementioned changes. This allows the optional
> creation of packages with the unmodified pacnew files when they are available.
> This is the first time that I'm using git send-email. Let me know what I need
> to fix if anything is incorrect.

I will give your patch a review next, but a few tips for you:

1) If you are sending a single patch, there is no need for a cover
letter.  Just put comments below the "---" line in the patch.

2) A patch should try and do one thing.  That makes them easier to
review. It also means we can accept parts while waiting on other parts
to be revised if necessary.

3) Careful with whitespace.

> Xyne (1):
>   bacman: optionally include unmodified BACKUP files and fix other
>     errors
>  contrib/bacman.sh.in | 85 ++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 63 insertions(+), 22 deletions(-)

More information about the pacman-dev mailing list