[pacman-dev] [PATCH] updpkgsums: omit downloader output when capturing checksums

[Dave Reisner]

On Tue, Sep 17, 2013 at 02:02:00PM +0000, Xyne wrote:
> Download the source files with an invocation of makepkg before capturing the
> output of makepkg -g. Without this, data printed to STDOUT by the downloader is
> included in the PKGBUILD.
> ---

This works for me...

$ rm /mnt/Haven/sources/fuse-2.9.3.tar.gz
$ makepkg -g 2>stderr
sha1sums=('94bd1974a9f2173ac3c2cf122f9fa3c35996b88e'
          '3b42e37a741d4651099225987dc40e7f02a716ad')
$ cat stderr
==> Retrieving sources...
  -> Downloading fuse-2.9.3.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  558k  100  558k    0     0   480k      0  0:00:01  0:00:01 --:--:-- 5130k
  -> Found fuse.conf
==> Generating checksums for source files...

Can you explain more about how you ran into this?

>  contrib/updpkgsums.sh.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/contrib/updpkgsums.sh.in b/contrib/updpkgsums.sh.in
> index ffea96b..760c414 100644
> --- a/contrib/updpkgsums.sh.in
> +++ b/contrib/updpkgsums.sh.in
> @@ -72,6 +72,9 @@ if [[ ! -w . ]]; then
>  fi
>  
>  {
> +	# Download sources first to avoid downloader output in newsums array below.
> +	makepkg --verifysource -dp "$buildfile" >/dev/null 2>&1
> +
>  	# Generate the new sums and try to unlink the file before writing stdin back
>  	# into it. This final precaution shouldn't fail based on the previous checks,
>  	# but it's better to be extra careful before unlinking files.
> -- 
> 1.8.4
> 
>