[pacman-dev] [PATCH] Display old and new version in pacman -Qu output

Andrew Gregory andrew.gregory.8 at gmail.com
Sat Sep 21 14:14:15 EDT 2013


On 09/21/13 at 05:28pm, Florian Pritz wrote:
> This changes the output from "foo 1.0" to "foo 1.0 -> 1.1" which makes
> cronjobs that mail the -Qu output way more helpful.
> 
> Signed-off-by: Florian Pritz <bluewind at xinu.at>
> ---
>  src/pacman/query.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/pacman/query.c b/src/pacman/query.c
> index c9c82b9..a8499c0 100644
> --- a/src/pacman/query.c
> +++ b/src/pacman/query.c
> @@ -318,8 +318,11 @@ static int display(alpm_pkg_t *pkg)
>  			&& !config->op_q_changelog && !config->op_q_check) {
>  		if(!config->quiet) {
>  			const colstr_t *colstr = &config->colstr;
> -			printf("%s%s %s%s%s\n", colstr->title, alpm_pkg_get_name(pkg),
> -					colstr->version, alpm_pkg_get_version(pkg), colstr->nocolor);
> +			alpm_pkg_t *newpkg = alpm_sync_newversion(pkg,	alpm_get_syncdbs(config->handle));

Stray tab between arguments.

> +
> +			printf("%s%s %s%s%s -> %s%s%s\n", colstr->title, alpm_pkg_get_name(pkg),
> +					colstr->version, alpm_pkg_get_version(pkg), colstr->nocolor,
> +					colstr->version, alpm_pkg_get_version(newpkg), colstr->nocolor);

Qu isn't the only operation to use this function.  Running `pacman -Q pacman`
gives me: 

pacman 4.1.2-1 -> (null) 

I think we should probably limit the new version to Qu output, but we
definitely need to at least do a NULL check for newpkg.

>  		} else {
>  			printf("%s\n", alpm_pkg_get_name(pkg));
>  		}
> -- 
> 1.8.4
> 


More information about the pacman-dev mailing list