[pacman-dev] [PATCH 1] Simplify pmtest.generate and .run API (removed pacman parameter).

Allan McRae allan at archlinux.org
Mon Sep 30 22:43:17 EDT 2013


On 30/09/13 10:12, Jeremy Heiner wrote:
> Previously pmtest.__init__ received and cached the pmenv.root, and
> generate and run received the pmenv.pacman. Now __init__ receives and
> caches the pmenv, allowing any method to fetch root, pacman, or other
> pmenv goodies directly instead of needing the extra parameter.
> 
> Moved the "which fakeroot" and "which fakechroot" logic from
> pmtest up into pmenv. Repeating the probes and warnings for each
> test was a bit redundant.
> 

I have not reviewed these patches as you said you were going to resend
them without the format mangled.   But this looks like two spearate
changes to the test-suite and so should be two different patches.

A



More information about the pacman-dev mailing list