[pacman-dev] [PATCH 06/11] signing.c: remove useless error check

Andrew Gregory andrew.gregory.8 at gmail.com
Fri Aug 1 17:19:49 EDT 2014


CHECK_ERR checks gpg_err which is a local variable.  Calling
gpg_op_import_result cannot modify it.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 lib/libalpm/signing.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c
index e46fa2e..c0fb006 100644
--- a/lib/libalpm/signing.c
+++ b/lib/libalpm/signing.c
@@ -404,7 +404,6 @@ static int key_import(alpm_handle_t *handle, alpm_pgpkey_t *key)
 	gpg_err = gpgme_op_import_keys(ctx, keys);
 	CHECK_ERR();
 	result = gpgme_op_import_result(ctx);
-	CHECK_ERR();
 	/* we know we tried to import exactly one key, so check for this */
 	if(result->considered != 1 || !result->imports) {
 		_alpm_log(handle, ALPM_LOG_DEBUG, "could not import key, 0 results\n");
-- 
2.0.2


More information about the pacman-dev mailing list