[pacman-dev] [PATCH v2] makepkg: ensure vcs download tool are installed when required

[Andrew Gregory]

On 08/03/14 at 07:48pm, Allan McRae wrote:
> Add an array VCSCLIENTS to makepkg.conf that matches vcs source protocols
> to the package containing the software needed for handling the source.
> 
> Signed-off-by: Allan McRae <allan at archlinux.org>
> ---
> 
> v2. also check for vcs binary on system
> 
>  doc/makepkg.conf.5.txt |  5 ++++
>  scripts/makepkg.sh.in  | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 75 insertions(+)
> 
> diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt
> index af4df20..4dc3b38 100644
> --- a/doc/makepkg.conf.5.txt
> +++ b/doc/makepkg.conf.5.txt
> @@ -47,6 +47,11 @@ Options
>  	be replaced with the local file name, plus a ``.part'' extension, which allows
>  	makepkg to handle resuming file downloads.
>  
> +**VCSCLIENTS=(**\'protocol::package' ...**)**::
> +	Sets the packages required to fetch version controlled source files. When
> +	required, makepkg will check that these packages are installed or are included
> +	in the `depends` or `makedepends` arrays in the PKGBUILD.
> +
>  **CARCH=**"carch"::
>  	Specifies your computer architecture; possible values include such things
>  	as ``i686'', ``x86_64'', ``ppc'', etc. This should be automatically set on
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index f9e816f..40355b5 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -2402,6 +2402,71 @@ check_pkgver() {
>  	return $ret
>  }
>  
> +get_vcsclient() {
> +	local proto=${1%%+*}
> +
> +	local i
> +	for i in "${VCSCLIENT[@]}"; do

You still have a name mismatch between this and the documentation.