[pacman-dev] [PATCH] makepkg: properly correlate checksums for multiple sources

Allan McRae allan at archlinux.org
Tue Dec 23 23:04:04 UTC 2014

On 24/12/14 01:57, Dave Reisner wrote:
> Previously, we used a single boolean value to determine correlation of
> sources to checksums. Since the introduction of arch-specific sources,
> this is no longer sufficient, as we must ensure that we have checksums
> for (potentially) multiple source arrays.
> This change inlines the logic of have_sources to build an associative
> array of source array names, unsetting them as we discover their
> checksums. The error condition then becomes a non-empty correlation
> array.
> Fixes: https://bugs.archlinux.org/task/43192
> ---
> So, I wrote this patch this way because it presents an opportunity to actually
> call out in the "integrity checks missing" error, which arrays are missing
> checksum arrays. However, this of course necessitiates a string change. Is this
> something we want for maint, or should I submit a separate patch for master?

This is fine for maint.  String change can go to master.


More information about the pacman-dev mailing list