[pacman-dev] [PATCH] Remove logically dead code in _alpm_local_db_write

Allan McRae allan at archlinux.org
Wed Dec 24 03:19:06 UTC 2014


We can only get to cleanup: through fp being NULL due to fopen failing or
normal execution when fclose is called.

Signed-off-by: Allan McRae <allan at archlinux.org>
---
 lib/libalpm/be_local.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/libalpm/be_local.c b/lib/libalpm/be_local.c
index 0771aaf..2454cdc 100644
--- a/lib/libalpm/be_local.c
+++ b/lib/libalpm/be_local.c
@@ -1036,11 +1036,6 @@ int _alpm_local_db_write(alpm_db_t *db, alpm_pkg_t *info, alpm_dbinfrq_t inforeq
 
 cleanup:
 	umask(oldmask);
-
-	if(fp) {
-		fclose(fp);
-	}
-
 	return retval;
 }
 
-- 
2.2.1


More information about the pacman-dev mailing list