[pacman-dev] [PATCH 1/1] libalpm: add version information to alpm.h

Dave Reisner d at falconindy.com
Sun Dec 28 20:24:46 UTC 2014


On Sun, Dec 28, 2014 at 08:45:38PM +0100, Christian Hesse wrote:
> From: Christian Hesse <mail at eworm.de>
> 
> Programs linked against libalpm (for example packagekit) may want to use
> preprocessor macros to check version and choose correct API. This adds
> version information to alpm.h.
> 
> Signed-off-by: Christian Hesse <mail at eworm.de>
> ---
>  lib/libalpm/alpm.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/libalpm/alpm.h b/lib/libalpm/alpm.h
> index 91b9461..e3f6e67 100644
> --- a/lib/libalpm/alpm.h
> +++ b/lib/libalpm/alpm.h
> @@ -23,6 +23,14 @@
>  #ifndef _ALPM_H
>  #define _ALPM_H
>  
> +#define ALPM_VERSION "9.0.0"
> +
> +#define ALPM_VERSION_MAJOR 9
> +#define ALPM_VERSION_MINOR 0
> +#define ALPM_VERSION_PATCH 0
> +
> +#define ALPM_VERSION_NUMBER 0x090000
> +

+1 for the idea, -1 for the implementation. This should be generated
from constants defined nearby the actual versioning of the library.
Otherwise, someone will forget to bump this.

>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> -- 
> 2.2.1


More information about the pacman-dev mailing list