[pacman-dev] [PATCH 6/9] ini.c: remove unnecessary helper function

Allan McRae allan at archlinux.org
Mon Dec 29 04:06:06 UTC 2014


On 27/04/14 09:56, Andrew Gregory wrote:
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
>  src/pacman/ini.c | 52 +++++++++++++++++-----------------------------------
>  1 file changed, 17 insertions(+), 35 deletions(-)
> 
> diff --git a/src/pacman/ini.c b/src/pacman/ini.c
> index dc1fb7a..5c5232d 100644
> --- a/src/pacman/ini.c
> +++ b/src/pacman/ini.c
> @@ -27,20 +27,28 @@
>  #include "util.h"
>  
>  /**
> - * @brief INI parser backend.
> + * @brief Parse a pacman-style INI config file.
>   *
>   * @param file path to the config file
>   * @param cb callback for key/value pairs
>   * @param data caller defined data to be passed to the callback
> - * @param section_name the name of the current section
> - * @param line buffer to read into, must be at least PATH_MAX long
>   *
>   * @return 0 on success, 1 on parsing errors, the callback return value
>   * otherwise
> + *
> + * @note The callback will be called at the beginning of each section with an
> + * empty key and value, for each key/value pair, and when parsing is complete
> + * with all arguments except @a data empty.

You removed the final callback in patch 4/9.   The documentation should
have been updated there.


More information about the pacman-dev mailing list