[pacman-dev] [PATCHv2] _alpm_sync_prepare: fix unresolvable packages leak

Allan McRae allan at archlinux.org
Fri Feb 7 18:59:07 EST 2014


On 07/02/14 11:49, Andrew Gregory wrote:
> If the user opted not to remove the unresolvable packages from the
> transaction, the list was neither free'd nor saved to the transaction to
> be free'd in trans_release.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
> 
> This supersedes patch 1/8 (avoid double freeing unresovable packages) as well,
> which was only necessary because the previous version made it possible for
> packages to be in both trans->add and trans-unresolvable.

Much better!   And I note all tests pass with --valgrind now.

Allan



More information about the pacman-dev mailing list