[pacman-dev] [PATCH v2 3/7] Update the event callback

Allan McRae allan at archlinux.org
Wed Jan 15 05:07:47 EST 2014


On 11/01/14 01:25, Olivier Brunel wrote:
> Instead of using two void* arguments for all events, we now send one
> pointer to an alpm_event_t struct. This contains the type of event that
> was triggered.
> 
> With this information, the pointer can then be typecasted to the
> event-specific struct in order to get additional arguments.
> 
> Signed-off-by: Olivier Brunel <jjk at jjacky.com>
> ---
>  lib/libalpm/add.c     |  31 ++++++-----
>  lib/libalpm/alpm.h    | 148 +++++++++++++++++++++++++++++---------------------
>  lib/libalpm/be_sync.c |   6 +-
>  lib/libalpm/handle.h  |   4 +-
>  lib/libalpm/remove.c  |  25 +++++++--
>  lib/libalpm/sync.c    |  81 +++++++++++++++++++--------
>  lib/libalpm/util.c    |   6 +-
>  src/pacman/callback.c |  87 ++++++++++++++++-------------
>  src/pacman/callback.h |   2 +-
>  9 files changed, 241 insertions(+), 149 deletions(-)
> 

I'd like someone else to comment on this before I pull it given the size
of the patch.   It looks good to me.

Allan




More information about the pacman-dev mailing list