[pacman-dev] [PATCH 4/5] pmtest: use valgrind --child-silent-after-fork

[Dan McGee]

On Mon, Jan 6, 2014 at 2:19 PM, Andrew Gregory
<andrew.gregory.8 at gmail.com>wrote:

> Silences false warnings after alpm forks to run install scripts.
>
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
>
We didn't actually run install scripts in the test suite before if I
remember right, so there was likely no need for this option before. Seems
reasonable to add, especially given these forks are short-lived anyway and
they can just clean themselves up.


>  test/pacman/pmtest.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/pacman/pmtest.py b/test/pacman/pmtest.py
> index 1c3ea7c..e780a6d 100644
> --- a/test/pacman/pmtest.py
> +++ b/test/pacman/pmtest.py
> @@ -221,6 +221,7 @@ def run(self, pacman):
>                  "--tool=memcheck", "--leak-check=full",
>                  "--show-reachable=yes",
>                  "--gen-suppressions=all",
> +                "--child-silent-after-fork=yes",
>                  "--log-file=%s" % os.path.join(self.root,
> "var/log/valgrind"),
>                  "--suppressions=%s" % suppfile])
>          cmd.extend([pacman["bin"],
> --
> 1.8.5.2
>
>
>