[pacman-dev] [PATCH 3/3] makepkg.conf(5): Improve accuracy of paths and option arguments for MAN_DIRS and DOC_DIRS

[Dan McGee]

On Thu, Jan 16, 2014 at 5:30 PM, Jason St. John <jstjohn at purdue.edu> wrote:

> Signed-off-by: Jason St. John <jstjohn at purdue.edu>
> ---
> The correct path is "/opt", not "opt/". I assume "opt/" was written
> originally
> because the correct option to use is "opt/". This patch corrects the
> "/opt" vs. "opt/"
> issue and still provides an explicit example of using "opt/" in these
> variables.
>
I'm not sure that this actually clarifies anything. Most paths in makepkg
docs and elsewhere are based on relative paths to $pkgdir. Also remember
that you can use --rootdir in pacman to install things in places besides /,
causing your new wording to not hold true.

-1 without further explanation as to why has been wrong.


>   doc/makepkg.conf.5.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/doc/makepkg.conf.5.txt b/doc/makepkg.conf.5.txt
> index c0e1e05..346e8e6 100644
> --- a/doc/makepkg.conf.5.txt
> +++ b/doc/makepkg.conf.5.txt
> @@ -203,14 +203,14 @@ Options
>  **MAN_DIRS=(**{usr{,/local}{,/share},opt/*}/{man,info} ...**)**::
>         If `zipman` is specified in the `OPTIONS` array, this variable will
>         instruct makepkg where to look to compress manual (man and info)
> -       pages. If you build packages that are located in opt/, you may need
> -       to add the directory to this array. *NOTE:* Do not add the leading
> +       pages. If you build packages that are located in `/opt`, you may
> need
> +       to add `opt/` to this array. *NOTE:* Do not add the leading
>         slash to the directory name.
>
>  **DOC_DIRS=(**usr/{,share/}{doc,gtk-doc} ...**)**::
>         If `!docs` is specified in the `OPTIONS` array, this variable will
>         instruct makepkg where to look to remove docs. If you build
> packages
> -       that are located in opt/, you may need to add the directory to this
> +       that are located in `/opt`, you may need to add `opt/` to this
>         array. *NOTE:* Do not add the leading slash to the directory name.
>
>  **PURGE_TARGETS=(**usr/{,share}/info/dir .podlist *.pod...**)**::
> --
> 1.8.5.3
>
>
>