[pacman-dev] [PATCH] Add test case for the perl 5.20 dependency breakage

Dan McGee dpmcgee at gmail.com
Sun Jun 1 10:22:19 EDT 2014


On Sun, Jun 1, 2014 at 8:47 AM, Andrew Gregory <andrew.gregory.8 at gmail.com>
wrote:

> On 06/01/14 at 02:21pm, Florian Pritz wrote:
> > This test currently fails.
> >
> > Signed-off-by: Florian Pritz <bluewind at xinu.at>
> > ---
> >  test/pacman/tests/sync-perl520-breakage.py | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >  create mode 100644 test/pacman/tests/sync-perl520-breakage.py
>
> All tests need to be listed in tests/pacman/tests/TESTS and failing
> tests need to set self.expectfailure = True.  This is also a rather
> more specific test name than any of our other tests.
>

Agreed on the first two points; I think it might be beneficial however to
start naming tests like this. One could even write a script that parsed
descriptions of existing tests and turned it into a possible filename.

e.g. sync900.py:
self.description = "Replace one package with another providing it"
-> "sync-replace-package-another-providing.py"

basically 1) grab the prefix, 2) drop the number, 3) drop common words*, 4)
concat with hyphens.

* common words in this were "one", "with", "it", but I can't imagine the
dictionary is much bigger than 20 or so words.

-Dan


More information about the pacman-dev mailing list