[pacman-dev] [PATCH] makepkg: Change comment to reflect non-armored sig
Allan McRae
allan at archlinux.org
Sun Jun 1 20:37:10 EDT 2014
On 01/06/14 19:24, Johannes Löthberg wrote:
> The comment above the signature generation line says that it will make a
> ASCII armored signature, which it no longer will and which pacman
> doesn't like.
>
> Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
> ---
> scripts/makepkg.sh.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 96e5349..4c1d1b3 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -2081,7 +2081,7 @@ create_signature() {
> if [[ -n $GPGKEY ]]; then
> SIGNWITHKEY="-u ${GPGKEY}"
> fi
> - # The signature will be generated directly in ascii-friendly format
> + # The signature will be generated in the binary OpenPGP format
> gpg --detach-sign --use-agent ${SIGNWITHKEY} --no-armor "$filename" &>/dev/null || ret=$?
>
Any objection to just removing that comment?
More information about the pacman-dev
mailing list