[pacman-dev] [PATCH] makepkg: Progress bar at package compression stage

Yanus Poluektovich ypoluektovich at gmail.com
Sat Jun 7 21:47:02 EDT 2014


On 06/08/2014 05:21 AM, Yanus Poluektovich wrote:
> On 06/08/2014 05:12 AM, Yanus Poluektovich wrote:
>> On 06/08/2014 12:30 AM, Dave Reisner wrote:
>>>> +        local uncompressed_size=$( du -sb "${comp_files[@]}" | awk
>>>> 'BEGIN {s=0} {s += $1} END {print s}' )
>>>
>>> Other usage of du in this script are necessarily done via a preprocessor
>>> replacement, i.e. @DUPATH@ @DUFLAGS@
>>>
>>> You'll need to follow this.
>>
>> Actually, after some grepping I found that there is only one other usage
>> of DUPATH/DUFLAGS in the entire codebase. It goes like this: first we
>> set DUFLAGS="-sk --apparent-size" in configure.ac, forcing it to report
>> sizes in kilobytes (the -k option), and then we multiply the result by
>> 1024 to get the useful number (lines 1905-1906 of
>> scripts/makepkg.sh.in). Do you think there's a reason behind it, or
>> should I just change "-sk" to "-sb"?
>
> Or, rather, it would be "-s -b" for Linux and Cygwin (if
> http://www.fiveanddime.net/cygwin-man-pages/usr/share/man/man1/du.1.html
> is to be believed) and "-A -s -B 1" for BSD.

Found the reason. Apparently it's Darwin that has a problem, not Cygwin. 
It doesn't have an option to show size in bytes.

So, new plan: leave the old du-related parts as they were and just pull 
the size from the .PKGINFO file.


More information about the pacman-dev mailing list