[pacman-dev] [PATCH] makepkg: Add a --noarchive option to inhibit archive creation

[Pierre Neidhardt]

On 14-03-02 18:20:34, Allan McRae wrote:
> > -		-i|--install)     INSTALL=1 ;;
> > +		-i|--install)     INSTALL=1; NOARCHIVE=0 ;;
> 
> I do not like this.  It means that if I specify both --install and
> --noarchive it does something, but that something depends on what order
> I specify them in.   Just do INSTALL=1;   That the end of this case
> statement, do a check if (( INSTALL && NOARCHIVE )) and do an error.
> 
> >  		--key)            shift; GPGKEY=$1 ;;
> >  		-L|--log)         LOGGING=1 ;;
> >  		-m|--nocolor)     USE_COLOR='n' ;;
> > 

'install' and 'noarchive' are mutually exclusive. One customary solution to
handle this is to let the last argument take precedence (a lot of coreutils do
that by the way). Which is not that weird in my opinion. I agree it might be
confusing in some cases. Anyway, if you do not like it, I'll remove it.

-- 
Pierre Neidhardt

History teaches us that men and nations behave wisely once they have
exhausted all other alternatives.
		-- Abba Eban