[pacman-dev] [PATCHv3 3/3] makepkg: Return non-zero when install_package() fails

[Pierre Neidhardt]

On 14-03-04 13:40:54, Allan McRae wrote:
> On 04/03/14 05:29, Pierre Neidhardt wrote:
> > Signed-off-by: Pierre Neidhardt <ambrevar at gmail.com>
> > ---
> >  scripts/makepkg.sh.in | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> > index aa02fa6..be1da7d 100644
> > --- a/scripts/makepkg.sh.in
> > +++ b/scripts/makepkg.sh.in
> > @@ -2100,7 +2100,7 @@ install_package() {
> >  
> >  	if ! run_pacman -U "${pkglist[@]}"; then
> >  		warning "$(gettext "Failed to install built package(s).")"
> > -		return 0
> > +		return 1
> >  	fi
> >  }
> >  
> 
> See commit deff57ce which references FS#13417 for history about this.

OK. I did this because on two occasions, makepkg returns "exit $?" after
install_package() has been called. Which is rather pointless then (and
confusing).

I will add a comment to install_package() and change the "exit $?" to "exit 0".


-- 
Pierre Neidhardt

No man is an island if he's on at least one mailing list.